Big Bug by Boundary Condition on Surfaces

Dear OGS Developer

I discovered a big bug by setting the boundary conditions. An example is on the Web SVN in the folder:

/branches/BGR/3d2d_surfaces

When you check the boundary condition output, there are no conditions on the surfaces OUT.

Who has changed the function to set the boundary condition? The version 5.10 works correct.

best regards

Herbert

Hi Herbert,
can you be a little bit more specific where in the code you think the
bug is located?
had) a general problem in the geometry routines. In general things seem
to work, but there are some dependencies on how you define the surfaces.
Can you check, if the OUT surface is found? (should be some indication
in the screen output)
For certain of my current 2D/3D examples I had to add the $EPS keyword
to the surface definitions in the GLI file. I found that I need a well
defined epsilon, as otherwise the surfaces were not found.
Greetings. Georg

···

From my experience with applying/defining surfaces the code has (and

On 12/12/2013 09:08 AM, Herbert Kunz wrote:

Dear OGS Developer

I discovered a big bug by setting the boundary conditions. An example
is on the Web SVN in the folder:
/branches/BGR/3d2d_surfaces
When you check the boundary condition output, there are no conditions
on the surfaces OUT.

Who has changed the function to set the boundary condition? The
version 5.10 works correct.

best regards

Herbert
--
You received this message because you are subscribed to the Google
Groups "ogs-devs" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to ogs-devs+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
PD Dr. Georg Kosakowski * Laboratory for Waste Management
Paul Scherrer Institut * 5232 Villigen/PSI * Switzerland
Phone: +41-56-3104743 * Fax: +41-56-3102821
Email: georg.kosakowski@psi.ch h323:+41563104743
homepage: http://people.web.psi.ch/kosakowski/

Dear Georg

I have tried the $Epsilon Keyword. This doesn't solve the problem.
I don' t developed the OGS code so I can't specified where in the code the bug is.
There must be a big change after the version 5.10. This, and older versions works properly.
I'm using the Keyword $BOUNDARY_CONDITION_OUTPUT in the PCS File.
With GINA you can check the Boundary Conditions on the Screen.

Herbert

···

-----Ursprüngliche Nachricht-----
Von: ogs-devs@googlegroups.com [mailto:ogs-devs@googlegroups.com] Im Auftrag von Georg Kosakowski
Gesendet: Donnerstag, 12. Dezember 2013 10:03
An: ogs-devs@googlegroups.com
Betreff: Re: Big Bug by Boundary Condition on Surfaces

Hi Herbert,
can you be a little bit more specific where in the code you think the bug is located?
From my experience with applying/defining surfaces the code has (and
had) a general problem in the geometry routines. In general things seem to work, but there are some dependencies on how you define the surfaces.
Can you check, if the OUT surface is found? (should be some indication in the screen output) For certain of my current 2D/3D examples I had to add the $EPS keyword to the surface definitions in the GLI file. I found that I need a well defined epsilon, as otherwise the surfaces were not found.
Greetings. Georg

On 12/12/2013 09:08 AM, Herbert Kunz wrote:

Dear OGS Developer

I discovered a big bug by setting the boundary conditions. An example
is on the Web SVN in the folder:
/branches/BGR/3d2d_surfaces
When you check the boundary condition output, there are no conditions
on the surfaces OUT.

Who has changed the function to set the boundary condition? The
version 5.10 works correct.

best regards

Herbert
--
You received this message because you are subscribed to the Google
Groups "ogs-devs" group.
To unsubscribe from this group and stop receiving emails from it, send
an email to ogs-devs+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

--
PD Dr. Georg Kosakowski * Laboratory for Waste Management Paul Scherrer Institut * 5232 Villigen/PSI * Switzerland
Phone: +41-56-3104743 * Fax: +41-56-3102821
Email: georg.kosakowski@psi.ch h323:+41563104743
homepage: http://people.web.psi.ch/kosakowski/

--
You received this message because you are subscribed to the Google Groups "ogs-devs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ogs-devs+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Dear Herbert,

thank you for providing test data. Which versions did you check after 5.10? Which of them worked?

I took a look into your gli file. There is no surface called OUT. You defined OUT_i, i = 1, ..., 16.
For those surfaces only the nodes at the top and the bottom of the given mesh are found with OGS-5.5.

I am investigating this problem further and inform you if I have found the reason for this.

Best regards,
tom

···

On 12/12/2013 10:03 AM, Georg Kosakowski wrote:

Hi Herbert,
can you be a little bit more specific where in the code you think the
bug is located?
From my experience with applying/defining surfaces the code has (and
had) a general problem in the geometry routines. In general things seem
to work, but there are some dependencies on how you define the surfaces.
Can you check, if the OUT surface is found? (should be some indication
in the screen output)
For certain of my current 2D/3D examples I had to add the $EPS keyword
to the surface definitions in the GLI file. I found that I need a well
defined epsilon, as otherwise the surfaces were not found.
Greetings. Georg

On 12/12/2013 09:08 AM, Herbert Kunz wrote:

Dear OGS Developer

I discovered a big bug by setting the boundary conditions. An example
is on the Web SVN in the folder:
/branches/BGR/3d2d_surfaces
When you check the boundary condition output, there are no conditions
on the surfaces OUT.

Who has changed the function to set the boundary condition? The
version 5.10 works correct.

best regards

Herbert

--
Dr. Thomas Fischer

Department of Environmental Informatics
Helmholtz Centre for Environmental Research GmbH - UFZ
Permoserstra�e 15 / 04318 Leipzig / Germany
Tel.: +49 341 235 - 1054 / Fax: +49 341 235 - 1939
thomas.fischer@ufz.de / http://www.ufz.de

Helmholtz-Zentrum f�r Umweltforschung GmbH - UFZ
Sitz der Gesellschaft: Leipzig
Registergericht: Amtsgericht Leipzig, Handelsregister Nr. B 4703
Vorsitzender des Aufsichtsrats: MinDirig Wilfried Kraus
Wissenschaftlicher Gesch�ftsf�hrer: Prof. Dr. Georg Teutsch
Administrative Gesch�ftsf�hrerin: Dr. Heike Gra�mann

Dear Tom

That's right. All the surfaces with the name OUT (OUT_1 and so on).
I have not all versions after 5.10. I tried different, but there are the same (wrong) result.
Thanks for your help.

Herbert

···

-----Ursprüngliche Nachricht-----
Von: ogs-devs@googlegroups.com [mailto:ogs-devs@googlegroups.com] Im Auftrag von Thomas Fischer
Gesendet: Donnerstag, 12. Dezember 2013 10:43
An: ogs-devs@googlegroups.com
Betreff: Re: Big Bug by Boundary Condition on Surfaces

On 12/12/2013 10:03 AM, Georg Kosakowski wrote:

Hi Herbert,
can you be a little bit more specific where in the code you think the
bug is located?
From my experience with applying/defining surfaces the code has (and
had) a general problem in the geometry routines. In general things
seem to work, but there are some dependencies on how you define the surfaces.
Can you check, if the OUT surface is found? (should be some indication
in the screen output) For certain of my current 2D/3D examples I had
to add the $EPS keyword to the surface definitions in the GLI file. I
found that I need a well defined epsilon, as otherwise the surfaces
were not found.
Greetings. Georg

On 12/12/2013 09:08 AM, Herbert Kunz wrote:

Dear OGS Developer

I discovered a big bug by setting the boundary conditions. An example
is on the Web SVN in the folder:
/branches/BGR/3d2d_surfaces
When you check the boundary condition output, there are no conditions
on the surfaces OUT.

Who has changed the function to set the boundary condition? The
version 5.10 works correct.

best regards

Herbert

Dear Herbert,

thank you for providing test data. Which versions did you check after 5.10? Which of them worked?

I took a look into your gli file. There is no surface called OUT. You defined OUT_i, i = 1, ..., 16.
For those surfaces only the nodes at the top and the bottom of the given mesh are found with OGS-5.5.

I am investigating this problem further and inform you if I have found the reason for this.

Best regards,
tom

--
Dr. Thomas Fischer

Department of Environmental Informatics
Helmholtz Centre for Environmental Research GmbH - UFZ Permoserstraße 15 / 04318 Leipzig / Germany
Tel.: +49 341 235 - 1054 / Fax: +49 341 235 - 1939 thomas.fischer@ufz.de / http://www.ufz.de

Helmholtz-Zentrum für Umweltforschung GmbH - UFZ Sitz der Gesellschaft: Leipzig
Registergericht: Amtsgericht Leipzig, Handelsregister Nr. B 4703 Vorsitzender des Aufsichtsrats: MinDirig Wilfried Kraus Wissenschaftlicher Geschäftsführer: Prof. Dr. Georg Teutsch Administrative Geschäftsführerin: Dr. Heike Graßmann

--
You received this message because you are subscribed to the Google Groups "ogs-devs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ogs-devs+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Dear Herbert,

to limit the effort to find the reason, can you provide the version number of the first version that did not work.

Best regards,
tom

···

On 12/12/2013 10:45 AM, Kunz, Herbert wrote:

Dear Tom

That's right. All the surfaces with the name OUT (OUT_1 and so on).
I have not all versions after 5.10. I tried different, but there are the same (wrong) result.
Thanks for your help.

Herbert

--
Dr. Thomas Fischer

Department of Environmental Informatics
Helmholtz Centre for Environmental Research GmbH - UFZ
Permoserstra�e 15 / 04318 Leipzig / Germany
Tel.: +49 341 235 - 1054 / Fax: +49 341 235 - 1939
thomas.fischer@ufz.de / http://www.ufz.de

Helmholtz-Zentrum f�r Umweltforschung GmbH - UFZ
Sitz der Gesellschaft: Leipzig
Registergericht: Amtsgericht Leipzig, Handelsregister Nr. B 4703
Vorsitzender des Aufsichtsrats: MinDirig Wilfried Kraus
Wissenschaftlicher Gesch�ftsf�hrer: Prof. Dr. Georg Teutsch
Administrative Gesch�ftsf�hrerin: Dr. Heike Gra�mann

As far as I tested, it doesn't work since v5.2.03.

best,
nori

···

On 12/12/2013 11:13 AM, Thomas Fischer wrote:

On 12/12/2013 10:45 AM, Kunz, Herbert wrote:

Dear Tom

That's right. All the surfaces with the name OUT (OUT_1 and so on).
I have not all versions after 5.10. I tried different, but there are
the same (wrong) result.
Thanks for your help.

Herbert

Dear Herbert,

to limit the effort to find the reason, can you provide the version
number of the first version that did not work.

Best regards,
tom

--
Dr.-Ing. Norihiro Watanabe
Department of Environmental Informatics (ENVINF)
Wissenschaftler

Helmholtz-Zentrum f�r Umweltforschung GmbH - UFZ
Helmholtz Centre for Environmental Research GmbH - UFZ
Permoserstra�e 15 / 04318 Leipzig / Germany

norihiro.watanabe@ufz.de / http://www.ufz.de
Telefon +49 341 235 1806

Sitz der Gesellschaft: Leipzig
Registergericht: Amtsgericht Leipzig, Handelsregister Nr. B 4703
Vorsitzender des Aufsichtsrats: MinDirig Wilfried Kraus
Wissenschaftlicher Gesch�ftsf�hrer: Prof. Dr. Georg Teutsch
Administrativer Gesch�ftsf�hrer: Dr. Heike Gra�mann

Hoi Nori,
only to make sure that I am not the bad guy :wink:
You mean that 5.2.02 works and 5.2.03 does not work, correct?
If 5.2.03 works and 5.2.04 does not work ...I will have to look what I
did wrong...
Greetings, Georg

···

On 12/12/2013 01:59 PM, Norihiro Watanabe wrote:

As far as I tested, it doesn't work since v5.2.03.

best,
nori

On 12/12/2013 11:13 AM, Thomas Fischer wrote:

On 12/12/2013 10:45 AM, Kunz, Herbert wrote:

Dear Tom

That's right. All the surfaces with the name OUT (OUT_1 and so on).
I have not all versions after 5.10. I tried different, but there are
the same (wrong) result.
Thanks for your help.

Herbert

Dear Herbert,

to limit the effort to find the reason, can you provide the version
number of the first version that did not work.

Best regards,
tom

--
PD Dr. Georg Kosakowski * Laboratory for Waste Management
Paul Scherrer Institut * 5232 Villigen/PSI * Switzerland
Phone: +41-56-3104743 * Fax: +41-56-3102821
Email: georg.kosakowski@psi.ch h323:+41563104743
homepage: http://people.web.psi.ch/kosakowski/

Hi Georg,

nobody is a bad guy, at least in ogs developers :wink:

yes, 5.2.02 works and 5.2.03 does not work, though I didn't check 5.2.04.

best,
Nori

···

On 12/13/2013 10:32 AM, Georg Kosakowski wrote:

Hoi Nori,
only to make sure that I am not the bad guy :wink:
You mean that 5.2.02 works and 5.2.03 does not work, correct?
If 5.2.03 works and 5.2.04 does not work ...I will have to look what I
did wrong...
Greetings, Georg

On 12/12/2013 01:59 PM, Norihiro Watanabe wrote:

As far as I tested, it doesn't work since v5.2.03.

best,
nori

On 12/12/2013 11:13 AM, Thomas Fischer wrote:

On 12/12/2013 10:45 AM, Kunz, Herbert wrote:

Dear Tom

That's right. All the surfaces with the name OUT (OUT_1 and so on).
I have not all versions after 5.10. I tried different, but there are
the same (wrong) result.
Thanks for your help.

Herbert

Dear Herbert,

to limit the effort to find the reason, can you provide the version
number of the first version that did not work.

Best regards,
tom

--
Dr.-Ing. Norihiro Watanabe
Department of Environmental Informatics (ENVINF)
Wissenschaftler

Helmholtz-Zentrum f�r Umweltforschung GmbH - UFZ
Helmholtz Centre for Environmental Research GmbH - UFZ
Permoserstra�e 15 / 04318 Leipzig / Germany

norihiro.watanabe@ufz.de / http://www.ufz.de
Telefon +49 341 235 1806

Sitz der Gesellschaft: Leipzig
Registergericht: Amtsgericht Leipzig, Handelsregister Nr. B 4703
Vorsitzender des Aufsichtsrats: MinDirig Wilfried Kraus
Wissenschaftlicher Gesch�ftsf�hrer: Prof. Dr. Georg Teutsch
Administrativer Gesch�ftsf�hrer: Dr. Heike Gra�mann

Hoi,
I am relieved that there are no bad guys here!
From what I see, there are multiple changes from 5.2.02 to 5.2.03 which
makes identification of the problem not easier....
Only a stupid question: who is working/responsible for solving the
issue? Is there a procedure implemented for assigning such things to
someone?
There is a ticket system in the wiki, but this seems a bit "out of use".
Greetings, Georg

···

On 12/13/2013 10:36 AM, Norihiro Watanabe wrote:

Hi Georg,

nobody is a bad guy, at least in ogs developers :wink:

yes, 5.2.02 works and 5.2.03 does not work, though I didn't check 5.2.04.

best,
Nori

On 12/13/2013 10:32 AM, Georg Kosakowski wrote:

Hoi Nori,
only to make sure that I am not the bad guy :wink:
You mean that 5.2.02 works and 5.2.03 does not work, correct?
If 5.2.03 works and 5.2.04 does not work ...I will have to look what I
did wrong...
Greetings, Georg

On 12/12/2013 01:59 PM, Norihiro Watanabe wrote:

As far as I tested, it doesn't work since v5.2.03.

best,
nori

On 12/12/2013 11:13 AM, Thomas Fischer wrote:

On 12/12/2013 10:45 AM, Kunz, Herbert wrote:

Dear Tom

That's right. All the surfaces with the name OUT (OUT_1 and so on).
I have not all versions after 5.10. I tried different, but there are
the same (wrong) result.
Thanks for your help.

Herbert

Dear Herbert,

to limit the effort to find the reason, can you provide the version
number of the first version that did not work.

Best regards,
tom

--
PD Dr. Georg Kosakowski * Laboratory for Waste Management
Paul Scherrer Institut * 5232 Villigen/PSI * Switzerland
Phone: +41-56-3104743 * Fax: +41-56-3102821
Email: georg.kosakowski@psi.ch h323:+41563104743
homepage: http://people.web.psi.ch/kosakowski/

Hi,

Tom is the best person who can solve the issue, as he implemented that part. I'll ask him

The ticket system in the wiki is not used anymore (and never really used). Officially (in leipzig group), bug reports are supposed to be submitted to

http://www.opengeosys.org/forum/

No we don't really have a procedure for solving reported bugs yet.

best,
nori

···

On 12/13/2013 10:45 AM, Georg Kosakowski wrote:

Hoi,
I am relieved that there are no bad guys here!
From what I see, there are multiple changes from 5.2.02 to 5.2.03 which
makes identification of the problem not easier....
Only a stupid question: who is working/responsible for solving the
issue? Is there a procedure implemented for assigning such things to
someone?
  There is a ticket system in the wiki, but this seems a bit "out of use".
Greetings, Georg

On 12/13/2013 10:36 AM, Norihiro Watanabe wrote:

Hi Georg,

nobody is a bad guy, at least in ogs developers :wink:

yes, 5.2.02 works and 5.2.03 does not work, though I didn't check 5.2.04.

best,
Nori

On 12/13/2013 10:32 AM, Georg Kosakowski wrote:

Hoi Nori,
only to make sure that I am not the bad guy :wink:
You mean that 5.2.02 works and 5.2.03 does not work, correct?
If 5.2.03 works and 5.2.04 does not work ...I will have to look what I
did wrong...
Greetings, Georg

On 12/12/2013 01:59 PM, Norihiro Watanabe wrote:

As far as I tested, it doesn't work since v5.2.03.

best,
nori

On 12/12/2013 11:13 AM, Thomas Fischer wrote:

On 12/12/2013 10:45 AM, Kunz, Herbert wrote:

Dear Tom

That's right. All the surfaces with the name OUT (OUT_1 and so on).
I have not all versions after 5.10. I tried different, but there are
the same (wrong) result.
Thanks for your help.

Herbert

Dear Herbert,

to limit the effort to find the reason, can you provide the version
number of the first version that did not work.

Best regards,
tom

--
Dr.-Ing. Norihiro Watanabe
Department of Environmental Informatics (ENVINF)
Wissenschaftler

Helmholtz-Zentrum f�r Umweltforschung GmbH - UFZ
Helmholtz Centre for Environmental Research GmbH - UFZ
Permoserstra�e 15 / 04318 Leipzig / Germany

norihiro.watanabe@ufz.de / http://www.ufz.de
Telefon +49 341 235 1806

Sitz der Gesellschaft: Leipzig
Registergericht: Amtsgericht Leipzig, Handelsregister Nr. B 4703
Vorsitzender des Aufsichtsrats: MinDirig Wilfried Kraus
Wissenschaftlicher Gesch�ftsf�hrer: Prof. Dr. Georg Teutsch
Administrativer Gesch�ftsf�hrer: Dr. Heike Gra�mann

Dear all,

I take care of the problem. I can not promise to solve it today.

Best regards
tom

···

--
Dr. Thomas Fischer

Department of Environmental Informatics
Helmholtz Centre for Environmental Research GmbH - UFZ
Permoserstra�e 15 / 04318 Leipzig / Germany
Tel.: +49 341 235 - 1054 / Fax: +49 341 235 - 1939
thomas.fischer@ufz.de / http://www.ufz.de

Helmholtz-Zentrum f�r Umweltforschung GmbH - UFZ
Sitz der Gesellschaft: Leipzig
Registergericht: Amtsgericht Leipzig, Handelsregister Nr. B 4703
Vorsitzender des Aufsichtsrats: MinDirig Wilfried Kraus
Wissenschaftlicher Gesch�ftsf�hrer: Prof. Dr. Georg Teutsch
Administrative Gesch�ftsf�hrerin: Dr. Heike Gra�mann

Dear all,

I uploaded changes in Triangle::containsPoint() method to the trunk. The benchmarks are all fine. Hope this fixes some problems. If not, please sen me test cases!

Best regards,
tom

···

--
Dr. Thomas Fischer

Department of Environmental Informatics
Helmholtz Centre for Environmental Research GmbH - UFZ
Permoserstra�e 15 / 04318 Leipzig / Germany
Tel.: +49 341 235 - 1054 / Fax: +49 341 235 - 1939
thomas.fischer@ufz.de / http://www.ufz.de

Helmholtz-Zentrum f�r Umweltforschung GmbH - UFZ
Sitz der Gesellschaft: Leipzig
Registergericht: Amtsgericht Leipzig, Handelsregister Nr. B 4703
Vorsitzender des Aufsichtsrats: MinDirig Wilfried Kraus
Wissenschaftlicher Gesch�ftsf�hrer: Prof. Dr. Georg Teutsch
Administrative Gesch�ftsf�hrerin: Dr. Heike Gra�mann

It would be nice if Herbert's problem (or simplified one if it's too big) is added into benchmark to ensure the same issue will not occur again in the future.

best,
nori

···

On 12/16/2013 08:59 AM, Thomas Fischer wrote:

Dear all,

I uploaded changes in Triangle::containsPoint() method to the trunk. The
benchmarks are all fine. Hope this fixes some problems. If not, please
sen me test cases!

Best regards,
tom

--
Dr.-Ing. Norihiro Watanabe
Department of Environmental Informatics (ENVINF)
Wissenschaftler

Helmholtz-Zentrum f�r Umweltforschung GmbH - UFZ
Helmholtz Centre for Environmental Research GmbH - UFZ
Permoserstra�e 15 / 04318 Leipzig / Germany

norihiro.watanabe@ufz.de / http://www.ufz.de
Telefon +49 341 235 1806

Sitz der Gesellschaft: Leipzig
Registergericht: Amtsgericht Leipzig, Handelsregister Nr. B 4703
Vorsitzender des Aufsichtsrats: MinDirig Wilfried Kraus
Wissenschaftlicher Gesch�ftsf�hrer: Prof. Dr. Georg Teutsch
Administrativer Gesch�ftsf�hrer: Dr. Heike Gra�mann