Hello there,
i have two questions regarding the ogs6 input file syntax:
- On your website Project file syntax (opengeosys.org) it reads that the .prj files are xml documents, there is a list of keywords, a example how to include other files but there is in fact (at least as far i could see) no complete description of your input file syntax.
→ What is the minimal set of madatory instructions for each process to get a valid result in return?
→ What are the optional parameter and their default values per process?
I could not find any of these informations and picking them one by one out of the multiple benchmark examples is cumbersome in my regard.
- Why is there no proper use of XML attributes?
Example 1:
...
<processes>
<process>
<name>THERMO_HYDRO_MECHANICS</name>
<type>THERMO_HYDRO_MECHANICS</type>
<integration_order>4</integration_order>
<dimension>2</dimension>
...
I think a better human-readable xml file would be:
...
<processes>
<process name="THERMO_HYDRO_MECHANICS" type="THERMO_HYDRO_MECHANICS"
integration_order="4" dimension="2">
...
Example 2:
...
<phases>
<phase>
<type>AqueousLiquid</type>
<properties>
<property>
<name>specific_heat_capacity</name>
<type>Constant</type>
<value>4280.0</value>
</property>
<property>
<name>thermal_conductivity</name>
<type>Constant</type>
<value>0.6</value>
</property>
<property>
...
alternatively:
...
<phases>
<phase type="AqueousLiquid">
<properties>
<property name="specific_heat_capacity" type="Constant">4280.0</property>
<property name="thermal_conductivity" type="Constant">0.6</property>
...
Sometimes XML Elements seems to be ambigious
In a benchmark (square_1e2_lin.prj) i could find
...
<process_variables>
<displacement>displacement</displacement>
<pressure>pressure</pressure>
<temperature>temperature</temperature>
</process_variables>
...
at Project file syntax (opengeosys.org) it is written
...
<process_variables>
<process_variable>pressure</process_variable>
</process_variables>
...
My suggestion would be something like
...
<process_variables>
<variable type="displacement" name="displ1" />
<variable type="pressure" name="pres1" />
<variable type="temperature" name="temp1" />
</process_variables>
...
I think proper use of XML attributes (Pair(name,value)) would greatly simplify reading and writing ogs6 input files, as they could mostly share the same names (type, name,…).
Futhermore I think it would help to define and describe some standard xml elements which are needed to create a valid prj-file (if not already available).
Just my two cents…
Best, Max