Version request

Dear OGS developers,

I'd like to make a small update of trunk in this week. Changes are only that a thermal expansion term is added to LIQUID_FLOW. I'll also provide one benchmark example. If there is no objection, I will update the trunk on Thursday.

Kind regards,
Norihiro

···

--
Norihiro Watanabe
Department of Environmental Informatics (ENVINF)
Wissenschaftler

Helmholtz-Zentrum f�r Umweltforschung GmbH - UFZ
Helmholtz Centre for Environmental Research GmbH - UFZ
Permoserstra�e 15 / 04318 Leipzig / Germany

norihiro.watanabe@ufz.de / http://www.ufz.de
Telefon +49 341 235 1806

Sitz der Gesellschaft: Leipzig
Registergericht: Amtsgericht Leipzig, Handelsregister Nr. B 4703
Vorsitzender des Aufsichtsrats: MinDirig Wilfried Kraus
Wissenschaftlicher Gesch�ftsf�hrer: Prof. Dr. Georg Teutsch
Administrativer Gesch�ftsf�hrer: Dr. Heike Gra�mann

Dear Nori,

You have to update first because I committed some changes this morning.

Wenqing

···

On 13.11.2012 18:09, Norihiro Watanabe wrote:

Dear OGS developers,

I'd like to make a small update of trunk in this week. Changes are only that a thermal expansion term is added to LIQUID_FLOW. I'll also provide one benchmark example. If there is no objection, I will update the trunk on Thursday.

Kind regards,
Norihiro

Dear OGS developers,

I want to update some output for groundwater model calibration / water balance in the trunk this week. If there are no objections I will close the trunk on Wednesday.

Kind regards,

Jens

···

2012/11/13 Wenqing Wang wenqing.wang@ufz.de

Dear Nori,

You have to update first because I committed some changes this morning.

Wenqing

On 13.11.2012 18:09, Norihiro Watanabe wrote:

Dear OGS developers,

I’d like to make a small update of trunk in this week. Changes are only that a thermal expansion term is added to LIQUID_FLOW. I’ll also provide one benchmark example. If there is no objection, I will update the trunk on Thursday.

Kind regards,

Norihiro

Hoi Jens,
ich habe gerade noch einen "Fehler" in rf_time_new.cpp gefunden. Kannst du einen Bugfix mit in deine Version (release) einbauen?
Das Problem tritt auf, wenn man Richards_flow + andere Prozesse nicht vom Zeitpunkt t=0 started, also z.B. in der tim Datei
START_TIME
  1e9
setzt.
Bei mir tritt das bei Restart Rechnungen auf...
Da w�hrend der Initialisierung last_active_time = 0.0 gesetzt wird, wird in problem.cpp line 884
             m_tim->time_step_length = next_time - m_tim->last_active_time;
falsch berechnet :wink:

Ich schlage vor, in rf_time_new.cpp line 197 etwas einzuf�gen und last_active_time =time_start zu setzten...etwa so

         if(line_string.find("$TIME_START") != std::string::npos)
         {
             line.str(GetLineFromFile1(tim_file));
             line >> time_start;
             last_active_time=time_start; //KG44: I would propose this
             line.clear();
             continue;
         }

Herzlichen Dank, Georg

···

--
PD Dr. Georg Kosakowski * Laboratory for Waste Management
Paul Scherrer Institut * 5232 Villigen/PSI * Switzerland
Phone: +41-56-3104743 * Fax: +41-56-3102821
Email: georg.kosakowski@psi.ch h323:+41563104743
homepage: http://people.web.psi.ch/kosakowski/

Oops, that is my fault I think, should have thought of that issue. Georg’s fix seems reasonable, and should take care of it.

···

On Tuesday, December 4, 2012, Georg Kosakowski wrote:

Hoi Jens,

ich habe gerade noch einen “Fehler” in rf_time_new.cpp gefunden. Kannst du einen Bugfix mit in deine Version (release) einbauen?

Das Problem tritt auf, wenn man Richards_flow + andere Prozesse nicht vom Zeitpunkt t=0 started, also z.B. in der tim Datei

START_TIME

1e9

setzt.

Bei mir tritt das bei Restart Rechnungen auf…

Da während der Initialisierung last_active_time = 0.0 gesetzt wird, wird in problem.cpp line 884

        m_tim->time_step_length = next_time - m_tim->last_active_time;

falsch berechnet :wink:

Ich schlage vor, in rf_time_new.cpp line 197 etwas einzufügen und last_active_time =time_start zu setzten…etwa so

    if(line_string.find("$TIME_START") != std::string::npos)

    {

        line.str(GetLineFromFile1(tim_file));

        line >> time_start;

        last_active_time=time_start; //KG44: I would propose this

        line.clear();

        continue;

    }

Herzlichen Dank, Georg

PD Dr. Georg Kosakowski * Laboratory for Waste Management

Paul Scherrer Institut * 5232 Villigen/PSI * Switzerland

Phone: +41-56-3104743 * Fax: +41-56-3102821

Email: georg.kosakowski@psi.ch h323:+41563104743

homepage: http://people.web.psi.ch/kosakowski/